Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ecdh-curve optional #436

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented May 7, 2022

Pull Request (PR) description

Make ecdh-curve optional, if no dh key is defined.

In OpenVPN 2.5 (I initially test the EC keys with OpenVPN 2.4), define ecdh-curve will throw an warning

Consider setting groups/curves preference with tls-groups instead of forcing a specific curve with ecdh-curve.

This Pull Request (PR) fixes the following issues

@jkroepke
Copy link
Contributor Author

jkroepke commented May 7, 2022

@bastelfreak BC change cloud be discussable, it would not break an existing OVPN setup.

@jkroepke
Copy link
Contributor Author

Can I help here to move forward here?

@bastelfreak
Copy link
Member

This will purge ecdh-curve from the config. doesn't that effect existing configurations? Or is secp384r1 the default value?

@jkroepke
Copy link
Contributor Author

If ecdh-curve is purged from config, the defaults will be inherit from tls-groups option. The default is X25519:secp256r1:X448:secp521r1:secp384r1

If you do not force the ecdh curve by using --ecdh-curve, the groups for ecdh will also be picked from this list.

https://build.openvpn.net/man/openvpn-2.5/openvpn.8.html

@bastelfreak bastelfreak merged commit decd4d3 into voxpupuli:master Aug 24, 2022
@bastelfreak bastelfreak added enhancement New feature or request and removed backwards-incompatible labels Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants